The easy joke about Lois Lane is something like “If she’s such a good reporter, how come she can’t tell that the guy she works with is Superman except he’s wearing glasses?” This is all well and good when done in jest, but sometimes people who don’t care for Lois will use this as actual evidence that she’s not a good reporter. The temerity!
Over the decades of Superman’s existence we’ve had almost every kind of story play out with these characters. More often than not these days, Lois does find out that Clark is Superman. I don’t know that there’s been a Superman continuity for decades in which Lois doesn’t find out Clark’s secret identity (actually, maybe the Superman Returns movie, but I legitimately don’t recall). When people mock Lois in this way, they’re actually mocking the Silver Age Lois, which is probably still the most iconic version of the character, which is a shame because it’s not the best by any means.
But even that Silver Age Lois was suspicious that Clark and Superman were one-and-the-same, right? You Loismockers have to admit that. And how did Silver Age Superman escape her suspicion? He used robot duplicates, hypnotism, amnesia, shapechangers, time-travel, and all manner of other Super-Schemes to throw her off the tail. Superman had to use these high-concept deity-level tactics to avoid being found out by Lois Lane, ordinary human reporter. And she was STILL suspicious of him. If anything, Lois Lane’s inability to prove the Clark-Superman connection in that era is a sign that she’s capable of rivalling a human god in a grand intellectual game. Lois Lane is not a bad reporter, people. She’s a super-reporter.